Skip to content

Commit

Permalink
[extractor] Do not warn for invalid chapter data in description
Browse files Browse the repository at this point in the history
  • Loading branch information
pukkandan committed Apr 16, 2023
1 parent 7666b93 commit 84ffeb7
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions yt_dlp/extractor/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -3658,18 +3658,22 @@ def _extract_chapters_helper(self, chapter_list, start_function, title_function,
'start_time': start_function(chapter),
'title': title_function(chapter),
} for chapter in chapter_list or []]
if not strict:
if strict:
warn = self.report_warning
else:
warn = self.write_debug
chapter_list.sort(key=lambda c: c['start_time'] or 0)

chapters = [{'start_time': 0}]
for idx, chapter in enumerate(chapter_list):
if chapter['start_time'] is None:
self.report_warning(f'Incomplete chapter {idx}')
warn(f'Incomplete chapter {idx}')
elif chapters[-1]['start_time'] <= chapter['start_time'] <= duration:
chapters.append(chapter)
elif chapter not in chapters:
self.report_warning(
f'Invalid start time ({chapter["start_time"]} < {chapters[-1]["start_time"]}) for chapter "{chapter["title"]}"')
issue = (f'{chapter["start_time"]} > {duration}' if chapter['start_time'] > duration
else f'{chapter["start_time"]} < {chapters[-1]["start_time"]}')
warn(f'Invalid start time ({issue}) for chapter "{chapter["title"]}"')
return chapters[1:]

def _extract_chapters_from_description(self, description, duration):
Expand Down

0 comments on commit 84ffeb7

Please sign in to comment.