-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BEL namespace to SCOMP and SFAM #184
Comments
Closes sorgerlab#184 Note: "MAPK Erk1/3 Family" exists as an equivalence in famplex, but it's not actually in the selventa namespace. Should we assign it our own F number?
I think we're talking about different things. SFAM and SCOMP are actually relatively recent, and these mappings were done with respect to a version of BEL where they weren't used yet, hence the differences. "MAPK Erk1/3 Family" is a real BEL family that used to exist. |
I saw the way this list was generated was by processing the selventa large corpus. I didn't realize that there's a older version of the large corpus that doesn't use SFAM and SCOMP! |
You can see in this file: https://raw.githubusercontent.com/sorgerlab/indra/de517e376256c61a3f91356bc8c95427febd8282/data/large_corpus.bel that the relevant namespaces that I used to import many families/complexes and curate mappings to FamPlex are PFH and NCH:
At the time I didn't think these BEL namespaces were important beyond being able to map them when encountered. I then occasionally added things from SCOMP/SFAM later, again without splitting into a new namespace, to be able to process newer versions of Selventa BEL files where these appeared. I agree it would be good to update these since it's unlikely we will ever need to process old BEL content, we just need to be a bit careful that things stay operational downstream. |
Closes sorgerlab#184 Note: "MAPK Erk1/3 Family" exists as an equivalence in famplex, but it's not actually in the selventa namespace. Should we assign it our own F number?
I think for historic reasons, the SCOMP and SFAM namespaces were combine to BEL for the purposes of famplex. This is a bit problematic because the information about the original namespace is lost. Even more confusing, these are actually the names of the entities and not their selventa identifiers
I added all of the selventa namespaces to PyOBO in biopragmatics/pyobo#114. Would it break a lot of things in INDRA if we started updating these in famplex?
One compromise would be to add the additional references then just filter out the BEL namespace information in places that don't require it
The text was updated successfully, but these errors were encountered: