Add telemetry events around the HTTP calls. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorentwo
requested changes
Jun 13, 2020
lib/http.ex
Outdated
| case response do | ||
| catch | ||
| kind, reason -> | ||
| stacktrace = System.stacktrace() |
There was a problem hiding this comment.
This is deprecated, we need to use __STACKTRACE__ instead. If the minimum elixir version is too low we can bump it as well.
lib/http.ex
Outdated
| end | ||
| end | ||
|
|
||
| defp telemetry_started do |
There was a problem hiding this comment.
Telemetry is getting ubiquitous enough and is light weight enough that I think we can have it as a non-optional dependency.
This means we need to bump the required minimum version of Elixir to 1.7
sorentwo
approved these changes
Jun 14, 2020
|
Awesome work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add optional Telemetry events around the HTTP calls to BrainTree. See the README for the shape of the events.
Telemetry is added as an optional dependency, and the code will skip the telemetry calls if the telemetry application is not running