Allow configuration of sandbox endpoint for testing #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows sandbox endpoint configuration, uses `@sandbox_endpoint` as default * Builds keyword list at runtime to prevent stale config * Updates readme to inform library users of new config
chris-allen-pepsi
approved these changes
May 11, 2020
sorentwo
approved these changes
May 11, 2020
|
I've release v0.11.0 with these changes, plus a lot of others. It had been over a year since the last release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to use
Bypassto test code that calls out toBraintree. Because the endpoints are hardcoded, this is not possible without modifying the library. I would prefer to not be using a fork of the library though, so this PR would solve that.All in all, this PR does the following:
:braintreewith config key:sandbox_endpointwhich uses@sandbox_endpointif no config is provided@production_endpointREADME.mdto inform library users of new config option