Add dialyxir and fix all the typespecs #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use dialyzer in a project of mine using this library and noticed errors that I couldn't fix without touching this library. Here are some fixes I think will help, but there's plenty of room for other improvements. At least I think this is a good start.
The main issues:
Map.t
doesn't exist, it should just bemap
[]
I think matches only "empty list".[any]
is a generic "list of zero or more anything"new/1
was being defined inBraintree.Construction
, I removed the typespecs for all the overridden ones, because dialyzer can't handle more than one typespec per functionHope this helps, let me know if you'd like anything changed! ;)