Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to alpine 3.6 and glibc 2.28-r0 #15

Merged
merged 2 commits into from
Dec 2, 2018
Merged

Conversation

Francesco149
Copy link
Contributor

I noticed the adb version in the image was old enough to be incompatible with adb 1.0.40 clients so I decided to rebuild it and it wasn't building due to the dead sgerrand pubkey url

I went ahead and updated everything so it builds again

oh yeah, and since docker tar's the entire working directory i added a .dockerignore to exclude files it doesnt need at build time

@sorccu sorccu merged commit c75516f into sorccu:master Dec 2, 2018
@sorccu
Copy link
Owner

sorccu commented Dec 2, 2018

Great patch. Wish docker hub sent an email when builds start failing.

gounthar added a commit to gounthar/docker-adb that referenced this pull request Dec 3, 2018
@gounthar
Copy link

gounthar commented Dec 3, 2018

I never got why this particular version of glibc was necessary. Could you please shortly elaborate?
Thanks a lot.

@Francesco149
Copy link
Contributor Author

I'm not actually sure the glibc bump was necessary

basically what happened is the old pubkey at https://raw.githubusercontent.com/andyshinn/alpine-pkg-glibc/master/sgerrand.rsa.pub 404's and the one at https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub is not necessarily the same that was used to sign glibc-2.23-r3{,-bin}.apk

you can try just using the new pubkey and the old apk's and see if it still builds, I just thought I'd go ahead and match the latest packages on sgerrand's repo while I was at it

@Francesco149
Copy link
Contributor Author

according to sgerrand's readme, Any previous reference to https://raw.githubusercontent.com/sgerrand/alpine-pkg-glibc/master/sgerrand.rsa.pub should be updated with immediate effect to https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub.

so in theory it should work with 2.23-r3 as well if you prefer using that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants