Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated_with_theme_checking_and_switching #1573

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

Kron1749
Copy link
Contributor

@Kron1749 Kron1749 commented Oct 16, 2024

Description

  • What does this PR do?

    • A brief explanation of the change, its purpose, and how it impacts the codebase.
  • Why is this change needed?

    • Describe the problem the PR solves or the feature it adds.

Type of change

  • Bug fix
  • New feature
  • Refactor (cleaning up code without changing functionality)
  • Documentation update
  • Tests
  • Other (describe below):

Checklist

  • Code adheres to coding guidelines and standards.
  • Linting and formatting checks have passed, no local issues.
  • Existing tests pass successfully, no local errors.
  • Pull request is linked to a relevant issue or task.
  • Tests are written for new features or fixes.
  • Documentation has been updated (if applicable).

Related Issue/Task


Testing

  • How has this been tested?
    • Tested on PC(Windows)
    • Tested on Mobile phone(android ) in browser
    • Tested in tg mini app with "Auto-Night Mode" in "System Default"
    • Tested in tg mini app with "Switch to Night/Day Mode"

Additional Notes

Enviroment https://exchange-1573.dev.sora2.tachi.soramitsu.co.jp/#/swap

Tg Bot - https://t.me/chagneTheme_bot/app

  • To test in TG Mini App need to:
  1. Go to settings
  2. Open Chat Settings
  3. Turn "Switch to Night/Day Mode" or test with "Auto-Night Mode" with "System Default"

Reviewer Tasks

  • Review logic for correctness and clarity.
  • Verify that the code is following best practices.
  • Test or review related areas if this PR affects other projects.

@Kron1749 Kron1749 added the experimental_environment This pr will be deployed on tachi cluster label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental_environment This pr will be deployed on tachi cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant