Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/point system v2 #1562

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from
Open

Feature/point system v2 #1562

wants to merge 32 commits into from

Conversation

Kron1749
Copy link
Contributor

@Kron1749 Kron1749 commented Oct 9, 2024

Description

  • What does this PR do?

    • Updated Point System, In Points tab added Tasks and Rewards
    • Used new data in tasks and rewards from indexer
    • Calculated total points for user
  • Why is this change needed?

    • Because the previous version of Point System was just an MVP, and we needed new version

Type of change

  • Bug fix
  • New feature
  • Refactor (cleaning up code without changing functionality)
  • Documentation update
  • Tests
  • Other (describe below):

Checklist

  • Code adheres to coding guidelines and standards.
  • Linting and formatting checks have passed, no local issues.
  • Existing tests pass successfully, no local errors.
  • Pull request is linked to a relevant issue or task.
  • Tests are written for new features or fixes.
  • Documentation has been updated (if applicable).

Related Issue/Task


Testing

  • How has this been tested?

    • Data from indexer is processed correctly
    • Clicking on every task,progress card shows correct data
    • Tested on default phones
  • Edge cases covered:

    • Tested when user has max level
    • Tested when user has progress that is more than max level
    • Tested that user could have maximum 60k points

Screenshots/Video/Link to dedicated environment (if applicable)

image

image

image


Additional Notes


Reviewer Tasks

  • Review logic for correctness and clarity.
  • Verify that the code is following best practices.
  • Test or review related areas if this PR affects other projects.

@Kron1749 Kron1749 added the experimental_environment This pr will be deployed on tachi cluster label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental_environment This pr will be deployed on tachi cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants