[LSE-01S] Inexistent Sanitization of Input Addresses

[fedealconada]

LSE-01S: Inexistent Sanitization of Input Addresses

Type	Severity	Location
Input Sanitization		L2SharedBridge.sol:L42-L46

Description:

The linked function(s) accept address arguments yet do not properly sanitize them.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

constructor(address _l1UsdcToken, address _l2UsdcToken) {
    L1_USDC_TOKEN = _l1UsdcToken;
    L2_USDC_TOKEN = _l2UsdcToken;
    _disableInitializers();
}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that each address specified is non-zero.