Fix issues that trigger compiler warnings with gcc 7.2.1

[berolinux]

Small issues: Misleading indentation looking like an if statement
ends in the wrong place, checking a variable of type bool for
values > true (impossible), etc.

The only change in here that has any effect other than silencing
warnings and reducing the headaches of someone trying to read
the code is changing the type of enablePowersaveOffload in
struct hdd_config: According to the code in wlan_hdd_main.c, it is
clearly meant to take 3 different values (0/nodeepsleep/deepsleep), so
it can't be bool.
Another option may be to keep it as bool and unify 0 and nodeepsleep
into false and changing deepsleep to true

Signed-off-by: Bernhard Rosenkränzer bero@lindev.ch

[jerpelea]

please do not add/ remove spaces because it will make things harder on the next rebase.

[berolinux]

Adding/changing the spaces is necessary to make the warnings (which the kernel's compiler wrapper script turns into errors) go away -- the indentation in those files is broken.
Here's a short snippet showing why this is necessary:

#include <stdio.h>
int main(int argc, char **argv) {
        if(1)
                puts("Test 1");
                puts("Test 2");
}
$ gcc -Wall -Werror test.c
test.c: In function ‘main’:
test.c:3:2: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
  if(1)
  ^~
test.c:5:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
   puts("Test 2");
   ^~~~
cc1: all warnings being treated as errors

The other fix would be allowing those warnings in the wrapper script, but that would never be accepted in the upstream kernel.

[berolinux]

Where is the upstream for this code? Fixing the indentation issue there is preferable because it wouldn't cause problems during next rebase...

[jerpelea]

the upstream is in code aurora and there is no way to submit code there

[jerpelea]

please split the pacth is 2 separate patches
1 indentation
2 boolean fixes
this will ease the rebase process

[jerpelea]

please update you PR so that I can merge it