Prevent receiving list of random changes for empty topic name #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, sometimes Gerrit sends empty topic field or Jenkins deserialise topic as empty string. To prevent receiving list of random changes for empty topic this change adds explicit checks.
And because we are using masked topic name (
{}
) to support spaces, commas and other things we end up in have full list of all gerrit changes (with some limit on gerrit side):Without mask (no entries found):
So, now we forcibly switch topic/topicObject to null if name is empty and check that we don't query changes for empty topic name.