Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installation Guide for nmos-cpp Using Conan #386

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

johanjino
Copy link
Contributor

Documentation to install nmos-cpp using Conan package manager. The guide includes instructions for installing Conan, detecting profiles, installing nmos-cpp, and running the applications on both Windows and Linux platforms.

johanjino and others added 8 commits April 8, 2024 19:04
- Added Linux equivalents
- Fixed typos

Co-authored-by: Gareth Sylvester-Bradley <31761158+garethsb@users.noreply.github.com>
- direct deploy Linux equivalent commands added
- Fixed formatting of %USERNAME%
Documentation to Install nmos-cpp with Conan 2
@jonathan-r-thorpe
Copy link
Contributor

Hi @johanjino - this looks good to me - well done :) I'll put any specific comments in line with the documents.

Comment on lines +13 to +17
If the python Scripts directory is not on the PATH you will get a warning like:
> WARNING: The script conan.exe is installed in 'C:\Users\\%USERNAME%\\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts' which is not on PATH.
> Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

On Windows, you can use _System Properties \> Environment Variables..._ to permanently add the directory to the user PATH. Restart the Command Prompt and run `conan --help` to ensure Conan is found.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all refers to Windows only so perhaps prefix the whole section with "On Windows, ..."?

Suggested change
If the python Scripts directory is not on the PATH you will get a warning like:
> WARNING: The script conan.exe is installed in 'C:\Users\\%USERNAME%\\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts' which is not on PATH.
> Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
On Windows, you can use _System Properties \> Environment Variables..._ to permanently add the directory to the user PATH. Restart the Command Prompt and run `conan --help` to ensure Conan is found.
On Windows, if the python Scripts directory is not on the PATH you will get a warning like:
> WARNING: The script conan.exe is installed in 'C:\Users\\%USERNAME%\\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\Scripts' which is not on PATH.
> Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Also on Windows, you can use _System Properties \> Environment Variables..._ to permanently add the directory to the user PATH. Restart the Command Prompt and run `conan --help` to ensure Conan is found.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That specific example message is from Windows, but the warning can also occur on Linux.

@jonathan-r-thorpe jonathan-r-thorpe merged commit 29578e7 into sony:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants