Skip to content

Add initial support for HighDPI on Wayland #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

vially
Copy link
Contributor

@vially vially commented Dec 29, 2022

Warning

This pull-request is currently marked as a draft because it depends on a couple of pull-requests which haven't been merged yet: #311, #312, #313.

This pull-request contains various fixes related to HighDPI support on Wayland. Most of the fixes involve using the current window scale where needed and keeping the buffer scale in sync with the window scale.

The screen recordings below show a basic app before and after these fixes. The most notable difference is getting rid of the blurriness and the oversized widgets when running on a HighDPI screen on Wayland.

before.webm
after.webm

TODO

Note: I agree to delegate all rights related to this PR to Sony.

@vially vially force-pushed the highdpi-on-wayland branch from ffcf0a0 to 14f94ec Compare December 29, 2022 22:50
@HidenoriMatsubayashi HidenoriMatsubayashi added enhancement New feature or request wayland Topics of Wayland labels Dec 30, 2022
@vially vially force-pushed the highdpi-on-wayland branch from 14f94ec to 1e9d1f0 Compare December 30, 2022 07:56
@vially vially marked this pull request as ready for review December 30, 2022 07:56
@vially vially force-pushed the highdpi-on-wayland branch from 1e9d1f0 to 5fe5cb9 Compare December 30, 2022 07:57
Copy link
Contributor

@HidenoriMatsubayashi HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I made two comments.

Signed-off-by: Valentin Hăloiu <valentin.haloiu@gmail.com>
@vially vially force-pushed the highdpi-on-wayland branch from 5fe5cb9 to 3aaff94 Compare December 30, 2022 17:48
@HidenoriMatsubayashi HidenoriMatsubayashi merged commit d88c3c5 into sony:master Dec 30, 2022
@HidenoriMatsubayashi
Copy link
Contributor

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wayland Topics of Wayland
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants