allow layouts to access context #12

yukukotani · 2023-11-01T14:29:16Z

Every handler except LayoutHandler can receive Context as a parameter. This PR allow LayoutHandler to access Context as well.

I know that I'm hasty and need more discussion. I just want to show you what I want by code!

Background

I'm working on kuma-ui/kuma-ui#364. I'd like to use Context as a request-scoped dictionary in LayoutHandler to provide elegant API.

Rough example:

const handler: LayoutHandler = ({ children, head, c }) => {
  return (
    <KumaRegistry context={c}>
      <html lang="en">
        <head>
          {head.createTags()}
          <KumaHead context={c} />
        </head>
        <body>...</body>
      </html>
    </KumaRegistry>
  );
}

yukukotani · 2023-11-01T14:33:38Z

src/types.ts

@@ -68,3 +69,5 @@ export type Route<E extends Env = Env, N = Node> = {
 }

 export type AppRoute<E extends Env = Env> = (app: Hono<E>) => void
+
+export type LayoutContext = Omit<Context | 'render', 'setRenderer'>


It would lead unexpected behavior to override the rendering in layouts, so omitting them here.

yusukebe · 2023-11-29T18:31:23Z

@yukukotani

Sorry for to be late. LGTM!

allow layouts to access context

e198a85

yukukotani commented Nov 1, 2023

View reviewed changes

yusukebe merged commit 45ae97c into sonikjs:main Nov 29, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow layouts to access context #12

allow layouts to access context #12

yukukotani commented Nov 1, 2023 •

edited

Loading

yukukotani Nov 1, 2023

yusukebe commented Nov 29, 2023

allow layouts to access context #12

allow layouts to access context #12

Conversation

yukukotani commented Nov 1, 2023 • edited Loading

Background

yukukotani Nov 1, 2023

Choose a reason for hiding this comment

yusukebe commented Nov 29, 2023

yukukotani commented Nov 1, 2023 •

edited

Loading