Open
Conversation
- Pattern Load Cues now define index and PLC ID in one go through new plcptr macro, introduced plcheader macro for individual lists, whitespace cleanup - Sonic animation script now uses sonani macro, Sonic frame IDs have been moved out of Constants.asm, deleted orphaned "Sonic (without frame IDs).asm" file - GameModeArray now uses gmptr macro, game mode ID labels have been moved out of Constants.asm - Reverted a handful of pointless object index ptr_ definitions (I guess this was never finished, and now it only served to add bloat) Perhaps one day a proper, reusable macro can be introduced that can be used across the source. At this stage, my motivation is to get rid of the confusing double definitions by any means necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps one day a proper, reusable macro can be introduced that can be used across the source. At this stage, my motivation is to get rid of the confusing double definitions by any means necessary.
(Eventually I also want to do something similar for the bgm/sfx definitions, but so far I haven't figured out an elegant solution that's also bit-perfect...)