fix(app): resolve menu-bar avatar from workspace, not repoRoot - #1931
Merged
Conversation
Avatar lives under the workspace assets/, not the code checkout; align both load sites (setupMenuBar, avatarImage) with the workspace contract. Stand: Echo Act IV Pro
qingyun-wu
approved these changes
Jul 6, 2026
qingyun-wu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — verified against the canonical resolver, not just the PR description.
src/util_paths.tsalready special-casesstand-avatar.png→join(ws, 'assets', filename)(both the existence-probing and non-probing paths), so dashboard/web-client surfaces resolve the avatar under the workspace. These two Swift sites were the last stragglers onrepoRoot.assets/doesn't exist in the repo at all (404 on the contents API) and the "refuse workspace/ contents in commits" CI guard means it never can — so the oldrepoRoot + "/assets/..."path was dead-by-default, and this change is strictly a fix, not a relocation risk.- Both load sites fail soft (
if let/guard let) if a workspace lacks the asset, same as before. - CI green incl. CLA.
Collaborator
|
Cold review at head ( Verified on this host (mac-local checkout):
Owner merges. |
Contributor
|
@cla-assistant check |
john-the-dev
approved these changes
Jul 6, 2026
john-the-dev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Two-line fix: repoRoot is the checkout path, not the user-data path — the avatar is served state, so workspace is correct. Matters when the workspace has been migrated or when the app bundle lives at a different path than the checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu-bar avatar is loaded from
repoRoot + "/assets/stand-avatar.png", but the avatar asset lives under the workspace, not the code checkout. Align both load sites (setupMenuBar,avatarImage) to resolve fromworkspace, per the workspace contract.Stand: Echo Act IV Pro