ShellCheck: Set directive 'extended-analysis=false' #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New directive available in ShellCheck v0.10.0. Fixes a memory issue with the DFA introduced in ShellCheck v0.9.0, which is why STL was stuck using v0.8.0. Now we can use newer ShellCheck version again!
|
ShellCheck v0.10.0 is very upset about a lot of things in SteamTinkerLaunch, but I'll open a separate PR to fix those. We will also need to update |
|
Tested a few times, ShellCheck completes a little faster (granted, there are quite a few warnings) but it won't eat up tons of RAM now. ShellCheck v0.10.0 won't work without this line, but works fine with it. I tested without the directive and it went up to 24gb ram used, I killed the process at that point. This is ready to merge I think. |
This was referenced Mar 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See also: koalaman/shellcheck#2652)
Prerequisite to #1056.
New directive available in ShellCheck v0.10.0. Fixes a memory issue with the DFA introduced in ShellCheck v0.9.0, which is why STL was stuck using v0.8.0. Now we can use newer ShellCheck version again!