SBS: Flatten some SBSVR-related functions #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
force-pushed
the
flatten-sbsvr-funcs
branch
from
40d749f to
c8bb679
Compare
|
This has been stale for a while but I think it's still good. Will do a ShellCheck and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the trend of recent PRs.
These functions were fairly ugly and difficult to read. They are also closely related as they're all SBSVR-related.
ShellCheck is green on this, but I don't have a headset to check on this with. So I'll give it a review and merge when I feel like the logic is sound.