Commandline: Flatten getGameDir #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works in testing, including with Non-Steam Games, but needs a rebase. |
sonic2kk
force-pushed
the
flatten-getgamedir
branch
from
adc3de2 to
cfa2a9b
Compare
sonic2kk
force-pushed
the
flatten-getgamedir
branch
from
cfa2a9b to
48fcda8
Compare
|
Rebased, but needs further testing. |
|
Tested, doesn't seem to cause any regressions. Will merge after shellcheck + version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of some ongoing work along the lines of #1031, and #1032 (and part of #1011).
This PR flattens out the nested logic in
getGameDir, to make it more maintainable and easier to read. There wasn't really any refactors here like in #1032, this was more like #1031 which just got flattened.