Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Jeff Rose's Overtone link in the CONTRIBUTORS.md file. #2898

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

amruth-acharya
Copy link
Contributor

In the "CONTRIBUTORS.md" file the Jeff Rose's Overtone link was directing to page not found. The link has been fixed.

Fixes #2897

…-It was directing to page not found. The link has been fixed and now it directs to Overtone project page. Fixes sonic-pi-net#2897
@ethancrawford
Copy link
Collaborator

Thanks! By the way, if you check the Extempore link, you'll notice that it redirects to a new address. (That's the original issue that I raised 😉) Any chance you can update that one too? 🙂

@amruth-acharya
Copy link
Contributor Author

Can you share the correct Extempore link which has to be added.

@ethancrawford
Copy link
Collaborator

It redirects to the right address currently 🙂

@ethancrawford
Copy link
Collaborator

ethancrawford commented Oct 20, 2021

(Oh, btw, we've worked out that linking a PR to an issue is not really worth it any more. That was helpful for automatically closing an issue when the PR was merged to the default branch, but we've decided that an issue is better off staying 'open' until the final release is made and ready for download with the issue's fix in it. (We'll mark it as having a solution a different way). So not really any need to link a PR to an issue any more 👍 )

@amruth-acharya
Copy link
Contributor Author

Is there any way i can change both?
I can change Extempore

@amruth-acharya
Copy link
Contributor Author

@ethancrawford my bad i thought Extempore link was the same .. I was confused in the .md file it shows http://extempore.moso.com.au but actual link is https://extemporelang.github.io/ any idea how did this change occurs?
You were saying to change it to ( https://extemporelang.github.io/ ) . now i get it. 😢

@ethancrawford
Copy link
Collaborator

It's ok 🙂
Yes, extempore should point to the github.io address, instead of the .com.au address 👍

@amruth-acharya
Copy link
Contributor Author

@ethancrawford sure! So the link won't get expired 🤞

@amruth-acharya
Copy link
Contributor Author

@ethancrawford sorry for the trouble

@ethancrawford
Copy link
Collaborator

No trouble - and thanks very much! 🙂

@samaaron samaaron merged commit 1d1db27 into sonic-pi-net:dev Oct 20, 2021
@samaaron
Copy link
Collaborator

Thanks for this :-)

@amruth-acharya
Copy link
Contributor Author

@samaaro always a pleasure 🤗 😭 🚀 .
@ethancrawford thank you very much 🤗

@ethancrawford
Copy link
Collaborator

Er... sorry for the confusion @samaaron @amruth-acharya , but the extempore link was still needing an update here 😉 this PR only updated the overtone link so far 🙂

@ethancrawford
Copy link
Collaborator

@amruth-acharya feel free to open a new PR for the extempore link change 😀

@amruth-acharya
Copy link
Contributor Author

sure! on it

@amruth-acharya
Copy link
Contributor Author

amruth-acharya commented Oct 20, 2021

@ethancrawford is it ok if add the link myself?
or should i keep it open?

@ethancrawford
Copy link
Collaborator

when you say 'add the link' what do you mean? 🙂

@amruth-acharya
Copy link
Contributor Author

when you say 'add the link' what do you mean? 🙂

I mean i 'll add extempore github( https://extemporelang.github.io/ ) link in contributor.md

@ethancrawford
Copy link
Collaborator

all you need to do is replace the old URL with that 🙂
See here:

* Andrew Sorensen - [Extempore](http://extempore.moso.com.au)

@amruth-acharya
Copy link
Contributor Author

ok should i make a new pr? 😃

@ethancrawford
Copy link
Collaborator

Sounds like the way to go 👍

@amruth-acharya
Copy link
Contributor Author

sorry for the trouble

@ethancrawford
Copy link
Collaborator

Not any trouble @amruth-acharya 😄 you're a valued part of the Sonic Pi contributor community, and we want you to feel successful for it too 🙂

@amruth-acharya
Copy link
Contributor Author

Not any trouble @amruth-acharya 😄 you're a valued part of the Sonic Pi contributor community, and we want you to feel successful for it too 🙂

Thanks a 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extempore project link outdated
3 participants