-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Jeff Rose's Overtone link in the CONTRIBUTORS.md file. #2898
Conversation
…-It was directing to page not found. The link has been fixed and now it directs to Overtone project page. Fixes sonic-pi-net#2897
Thanks! By the way, if you check the Extempore link, you'll notice that it redirects to a new address. (That's the original issue that I raised 😉) Any chance you can update that one too? 🙂 |
Can you share the correct Extempore link which has to be added. |
It redirects to the right address currently 🙂 |
(Oh, btw, we've worked out that linking a PR to an issue is not really worth it any more. That was helpful for automatically closing an issue when the PR was merged to the default branch, but we've decided that an issue is better off staying 'open' until the final release is made and ready for download with the issue's fix in it. (We'll mark it as having a solution a different way). So not really any need to link a PR to an issue any more 👍 ) |
Is there any way i can change both? |
@ethancrawford my bad i thought Extempore link was the same .. I was confused in the .md file it shows http://extempore.moso.com.au but actual link is https://extemporelang.github.io/ any idea how did this change occurs? |
It's ok 🙂 |
@ethancrawford sure! So the link won't get expired 🤞 |
@ethancrawford sorry for the trouble |
No trouble - and thanks very much! 🙂 |
Thanks for this :-) |
@samaaro always a pleasure 🤗 😭 🚀 . |
Er... sorry for the confusion @samaaron @amruth-acharya , but the extempore link was still needing an update here 😉 this PR only updated the overtone link so far 🙂 |
@amruth-acharya feel free to open a new PR for the extempore link change 😀 |
sure! on it |
@ethancrawford is it ok if add the link myself? |
when you say 'add the link' what do you mean? 🙂 |
I mean i 'll add extempore github( https://extemporelang.github.io/ ) link in contributor.md |
all you need to do is replace the old URL with that 🙂 Line 50 in f3ee189
|
ok should i make a new pr? 😃 |
Sounds like the way to go 👍 |
sorry for the trouble |
Not any trouble @amruth-acharya 😄 you're a valued part of the Sonic Pi contributor community, and we want you to feel successful for it too 🙂 |
Thanks a 🤗 |
In the "CONTRIBUTORS.md" file the Jeff Rose's Overtone link was directing to page not found. The link has been fixed.
Fixes #2897