Some 'Show and Hide' preferences forced 'on' after exiting focus mode

[ethancrawford]

Feel free to close if this intentional behaviour, and apologies if this was discussed previously somewhere, (I can't remember) but I've noticed that after exiting focus mode, several of the Sonic Pi 'Show and Hide' editor preferences are always forced 'on', rather than being restored to their pre-focus mode state.
It only affects the bottom three - Show cue log, Show buttons and Show tabs.
Eg:
Before focus mode, all show and hide preferences toggled off:

After focus mode, some show and hide preferences forced on:

[rbnpi]

Show Buttons and Show tabs ARE forced on after a restart. I remember this being discussed before, and Sam said it was so that you could find your way around if you couldn't remember short cut keys after starting SP to turn them on again. Not sure what you mean by "focus mode". If you click on a different app which changes focus and then back I don't get any changes with latest version here.

[ethancrawford]

Yeah, I remember after a restart. This behaviour occurs when exiting focus mode which is triggered by the F10 key.

[ethancrawford]

(It could well have been designed to occur in both situations, not sure, but thought I'd just check)

[rbnpi]

Ah OK. Yes I get the same behaviour as you. Interestingly if you use either the full screen tick or click on the green maximise button on the window and then revert to normal mode by unticking the full screen option or hovering at the top of the screen and re clicking the green button it doesn't alter the settings. So I guess you might call it a "bug" which can probably be altered by trawling through the QT in mainwindow.cpp.

[ethancrawford]

I can see the code responsible, but I'll wait to hear from @samaaron just to make sure :-)

[rbnpi]

Looks like it is by design:

void MainWindow::updateFocusMode(){
  if (focusMode) {
    full_screen->setChecked(true);
    show_tabs->setChecked(false);
    show_buttons->setChecked(false);
    show_log->setChecked(false);
    show_incoming_osc_log->setChecked(false);
  }
  else {
    full_screen->setChecked(false);
    show_tabs->setChecked(true);
    show_buttons->setChecked(true);
    show_incoming_osc_log->setChecked(true);
  }

I hadn't noticed because I don't use F10 but usually just click the green expand button on the window instead.

[ethancrawford]

Indeed. What threw me at first was that the standard log used to be forced on after exiting focus mode, but when Sam created the incoming OSC messages log, he made that one the one that was forced on instead. (I guess that was deliberate Sam?) Then I of course noticed that the other options all had their state hard coded as well, and wondered...

[samaaron]

Focus mode was made by @josephwilk and I'm not sure how many other people are using it as it's not documented anywhere.

Also, examination of the code to try and determine my thinking process is going to be tough as that c++ code is the worst code I've ever written in my life and is the story of me learning C++ badly, on the job ;-)

[samaaron]

Would anyone have an issue if we dropped focus mode?