-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vrrporch module #3315
base: master
Are you sure you want to change the base?
Adding vrrporch module #3315
Conversation
The committers listed above are authorized under a signed CLA. |
@philo-micas @madhupalu please help review |
Adam,
Sure, my team is already on it
…On Thu, Oct 3, 2024 at 3:12 PM Adam Yeung ***@***.***> wrote:
@philo-micas <https://github.com/philo-micas> @madhupalu
<https://github.com/madhupalu> please help review
—
Reply to this email directly, view it on GitHub
<#3315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALEIQNC2V7WRADAVYOV3NNDZZW6NRAVCNFSM6AAAAABPKHBD5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJSGQZDSMRVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
<https://aviznetworks.com/>
Madhu Paluru
Director, Engineering.
+1 408-455-5653
***@***.***
aviznetworks.com
[image: linkedin.png]
<https://www.linkedin.com/company/aviz-networks/> [image:
twitter.png] <https://twitter.com/aviznetworks> [image: youtube.png]
<https://www.youtube.com/channel/UCS0o0Lwv5M893eGpfAdOBNA>
|
|
||
bool operator== (const vrrp_key_t& rhs) const | ||
{ | ||
if (!(ip_addr == rhs.ip_addr) || port_name != rhs.port_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't "!(ip_addr == rhs.ip_addr)" be "(ip_addr != rhs.ip_addr)" similar to other case?
@@ -186,6 +186,8 @@ bool OrchDaemon::init() | |||
gDirectory.set(vnet_rt_orch); | |||
VRFOrch *vrf_orch = new VRFOrch(m_applDb, APP_VRF_TABLE_NAME, m_stateDb, STATE_VRF_OBJECT_TABLE_NAME); | |||
gDirectory.set(vrf_orch); | |||
VrrpOrch *vrrp_orch = new VrrpOrch(m_applDb, APP_VRRP_TABLE_NAME); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APP_VRRP_TABLE_NAME name is not defined. It needs to be defined in common/schema.h.
What I did
Adding vrrporch module
Why I did it
To listen to APPL_DB and program VRRP entities in SAI
How I verified it
UT
Details if related