Fix to enable/disable Lag member interface quickly when macsec session is up/down #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Set the Lag member state to enable/disable when the macsec session on the lag member interface go up/down.
Why I did it
Usually when macsec session goes down, since macsec is point to point -- th einterface also goes down and it is removed from LAG.
But in case the interface don't go down, and it is just macsec session that went down -- it waits for 90secs which is LACP timeout to get the interface out of LAG.
So with this fix -- macsec session timesout in 6sec .. and we immediately remove it out ot LAG, to minimize traffic imnpact.
How I verified it
Details if related