Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the API setBridgePortLearningFDB() and use setBridgePortLearnMode() only #3222

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DennisChiuEC
Copy link

@DennisChiuEC DennisChiuEC commented Jul 5, 2024

What I did
1.Remove the API setBridgePortLearningFDB()
2.Use setBridgePortLearnMode() as instead
3.Set PHY PORT's learning mode to forward during swss warm restart
which is derived from the setBridgePortLearningFDB() API called by swss warm restart.

Why I did it
Two API setBridgePortLearningFDB() and setBridgePortLearnMode() do the same thing which configured port learning mode.
The code can be refined to have only one API.

How I verified it

Details if related

@prsunny
Copy link
Collaborator

prsunny commented Sep 23, 2024

@DennisChiuEC , understand the motivation to use one api. What is the other change during warmboot? Is it fixing any issue? @dgsudharsan , @vaibhavhd for viz

@DennisChiuEC
Copy link
Author

The other change is aimed to make the L2 portchannel can forward packet during warmboot.
Maybe I should separate the change into another PR?
And this PR is focus on the change to use one api to set port learn mode.

@prsunny
Copy link
Collaborator

prsunny commented Sep 24, 2024

The other change is aimed to make the L2 portchannel can forward packet during warmboot. Maybe I should separate the change into another PR? And this PR is focus on the change to use one api to set port learn mode.

that would be great

@DennisChiuEC
Copy link
Author

The other change is aimed to make the L2 portchannel can forward packet during warmboot. Maybe I should separate the change into another PR? And this PR is focus on the change to use one api to set port learn mode.

that would be great

Done, has removed the change which is not related to refine the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants