[copporch]: fix the error when removing the copp group table. #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
wangshengjun
force-pushed
the
swss_copp
branch
from
a08ffe4
to
8939593
Compare
|
Right now we don't have COPP removal logic. Could you help add the corresponding unit tests? |
Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
The unit tests have committed, please take a review. To test the removal logic, #1038 must be merged. Or the copporch will trap into endless loop. |
stcheng
reviewed
Sep 17, 2019
Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…et#1039) generate xml, html and term report Signed-off-by: Guohan Lu <lguohan@gmail.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangshengjun wangshengjun@asterfusion.com
What I did
Removing the trap ids first when removing the copp group table entry.
Why I did it
When the copporch received a DEL event from redis DB, it just recreate the trap id with defaul attribute.The creation operation fails because that it already exists.
If the copp group table was removed, the trap ids which associated with the table group should delete too, no just recreate them with default attribute.
How I verified it
root@48S-sdd:/etc/swss/config.d# cat 00-copp.config_add.json
[
{
"COPP_TABLE:trap.group.arp": {
"trap_ids": "arp_req,arp_resp,neigh_discovery",
"trap_action":"copy",
"trap_priority":"4",
"queue": "4",
"meter_type":"packets",
"mode":"tr_tcm",
"cir":"600",
"cbs":"600",
"pir":"600",
"pbs":"600",
"red_action":"drop"
},
"OP": "SET"
}
]
root@48S-sdd:/etc/swss/config.d# cat 00-copp.config_del.json
[
{
"COPP_TABLE:trap.group.arp": {
"trap_ids": "arp_req,arp_resp,neigh_discovery",
"trap_action":"copy",
"trap_priority":"4",
"queue": "4",
"meter_type":"packets",
"mode":"tr_tcm",
"cir":"600",
"cbs":"600",
"pir":"600",
"pbs":"600",
"red_action":"drop"
},
"OP": "DEL"
}
]
When i load the delection configuration, it throws out error as follows:
Aug 27 19:56:43.853405 48S-sdd NOTICE swss#orchagent: :- removePolicer: Remove policer for trap group trap.group.arp
Aug 27 19:56:43.853506 48S-sdd ERR swss#orchagent: :- meta_generic_validation_create: attribute key SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE:8192; already exists, can't create
Aug 27 19:56:43.853608 48S-sdd ERR swss#orchagent: :- applyAttributesToTrapIds: Failed to create trap 8192, rv:-5
Aug 27 19:56:43.853699 48S-sdd ERR swss#orchagent: :- processCoppRule: Failed to reset traps to default trap group with default attributes
Aug 27 19:56:43.853788 48S-sdd ERR swss#orchagent: :- doTask: Processing copp task item failed, exiting
Details if related