Skip to content

[MSTP] Schema Support #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

wajahatrazi
Copy link

No description provided.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -483,6 +491,8 @@ namespace swss {
#define CFG_PAC_GLOBAL_CONFIG_TABLE "PAC_GLOBAL_CONFIG_TABLE"
#define CFG_PAC_HOSTAPD_GLOBAL_CONFIG_TABLE "HOSTAPD_GLOBAL_CONFIG_TABLE"


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra lines,

#define APP_STP_MST_INST_TABLE_NAME "STP_MST_INST_TABLE"
#define APP_STP_MST_PORT_TABLE_NAME "STP_MST_PORT_TABLE"
#define APP_STP_INST_PORT_FLUSH_TABLE_NAME "STP_INST_PORT_FLUSH_TABLE"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the tables as below

#define APP_STP_MST_TABLE_NAME "STP_MST_INST_TABLE"
#define APP_STP_MST_PORT_TABLE_NAME "STP_MST_PORT_TABLE"
#define [APP_STP_INST_PORT_FLUSH_TABLE_NAME "STP_INST_PORT_FLUSH_TABLE"

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@divyachandralekha
Copy link

Please follow up the build issue.

@wajahatrazi
Copy link
Author

Please follow up the build issue.

Can you elaborate ?

@divyachandralekha
Copy link

Please move the PR to official

@wajahatrazi wajahatrazi changed the title mstp_swsscommon_co_pr [MSTP] Schema Support Apr 29, 2025
@wajahatrazi wajahatrazi marked this pull request as ready for review April 29, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants