[vslib]: hostif enum capability query API support #1586
+192
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
please add unittests to satisfy code coverage |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
5fb557c to
c54eb01
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
c54eb01 to
6563625
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
previously approved these changes
Apr 24, 2025
dgsudharsan
approved these changes
May 2, 2025
kcudnik
reviewed
May 3, 2025
kcudnik
reviewed
May 3, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
previously approved these changes
May 5, 2025
|
could you also add unittests to cover this case ? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@kcudnik I added missing UT also for DEBUG_COUNTER. Can you please check now? |
kcudnik
approved these changes
May 6, 2025
rminnikanti
force-pushed
the
neighbor_miss
branch
from
6c7d3de to
62df57d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-sairedis |
|
Commenter does not have sufficient privileges for PR 1586 in repo sonic-net/sonic-sairedis |
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
May 22, 2025
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kcudnik Some of the PR checks are getting cancelled. All checks were passing a few days ago on this PR, but they started failing after I rebased the branch. Could you please help look into this? PR checks cancellation reason: |
|
this is due image ubuntu 20.04 is not available any more, i fixed it here:#1603 |
rminnikanti
force-pushed
the
neighbor_miss
branch
from
62df57d to
10bcf67
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1. vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP, attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE 2. Added UT for SAI_OBJECT_TYPE_HOSTIF_TRAP 3. Added UT for SAI_OBJECT_TYPE_DEBUG_COUNTER HLD: sonic-net/SONiC#1943 Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>
Added unittest comments to satisfy PR checks. Signed-off-by: Ravi Minnikanti <rminnikanti@marvell.com>
rminnikanti
force-pushed
the
neighbor_miss
branch
from
10bcf67 to
9d7c7b3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
vslib support for hostif trap object - SAI_OBJECT_TYPE_HOSTIF_TRAP,
attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE
Implementation returns all trap types as supported.
Why I did
Details in HLD: sonic-net/SONiC#1943
How I verified it
Verified with UT and DVS
Signed-off-by: Ravi Minnikanti rminnikanti@marvell.com