[p4-symbolic] Update hard-coded parser to match SAI P4. #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword Check :
/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build result:
sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
Starting local Bazel server and connecting to it...
INFO: Analyzed 512 targets (252 packages loaded, 22502 targets configured).
INFO: Found 512 targets...
INFO: From Compiling p4_symbolic/symbolic/values.cc [for host]:
In file included from ./p4_pdpi/netaddr/network_address.h:28,
from ./p4_pdpi/netaddr/ipv4_address.h:22,
from p4_symbolic/symbolic/values.cc:34:
./p4_pdpi/string_encodings/hex_string.h: In instantiation of 'std::string pdpi::BitsetToHexString(const std::bitset<_Nb>&) [with long unsigned int num_bits = 32; std::string = std::__cxx11::basic_string]':
./p4_pdpi/netaddr/network_address.h:86:67: required from 'std::string netaddr::NetworkAddress<num_bits, T>::ToHexString() const [with long unsigned int num_bits = 32; T = netaddr::Ipv4Address; std::string = std::__cxx11::basic_string]'
INFO: From Compiling p4_fuzzer/oracle_util_test.cc:
p4_fuzzer/oracle_util_test.cc:214:6: warning: 'void p4_fuzzer::{anonymous}::AddTableEntry(const p4::v1::TableEntry&, p4_fuzzer::SwitchState*)' defined but not used [-Wunused-function]
214 | void AddTableEntry(const TableEntry& table_entry, SwitchState* state) {
| ^~~~~~~~~~~~~
p4_fuzzer/oracle_util_test.cc:51:5: warning: 'int p4_fuzzer::{anonymous}::AclIngressTableSize()' defined but not used [-Wunused-function]
51 | int AclIngressTableSize() {
| ^~~~~~~~~~~~~~~~~~~
INFO: From Compiling p4_fuzzer/switch_state_test.cc:
p4_fuzzer/switch_state_test.cc:148:8: warning: 'p4::v1::Update p4_fuzzer::{anonymous}::MakePiUpdate(const pdpi::IrP4Info&, p4::v1::Update::Type, const pdpi::TableEntry&)' defined but not used [-Wunused-function]
148 | Update MakePiUpdate(const pdpi::IrP4Info& info, Update::Type type,
| ^~~~~~~~~~~~
INFO: Elapsed time: 130.564s, Critical Path: 14.92s
INFO: 104 processes: 19 internal, 85 linux-sandbox.
INFO: Build completed successfully, 104 total actions
Test result:
sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 512 targets (0 packages loaded, 323 targets configured).
INFO: Found 343 targets and 169 test targets...
INFO: Elapsed time: 101.703s, Critical Path: 44.69s
INFO: 178 processes: 208 linux-sandbox, 18 local.
INFO: Build completed successfully, 178 total actions
//gutil:collections_test PASSED in 0.5s
//gutil:io_test PASSED in 0.5s
//gutil:proto_matchers_test PASSED in 0.8s
//gutil:proto_ordering_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.8s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 0.9s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 2.5s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 0.8s
//sai_p4/tools:p4info_tools_test PASSED in 0.5s
//sai_p4/tools:packetio_tools_test PASSED in 0.7s
//thinkit:bazel_test_environment_test PASSED in 3.0s
//thinkit:generic_testbed_test PASSED in 1.0s
//thinkit:mock_control_device_test PASSED in 0.6s
//thinkit:mock_generic_testbed_test PASSED in 0.7s
//thinkit:mock_mirror_testbed_test PASSED in 0.7s
//thinkit:mock_ssh_client_test PASSED in 0.0s
//thinkit:mock_switch_test PASSED in 0.6s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.7s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 44.6s
Stats over 5 runs: max = 44.6s, min = 1.1s, avg = 13.1s, dev = 15.9s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.8s
Stats over 5 runs: max = 0.8s, min = 0.7s, avg = 0.7s, dev = 0.0s
Executed 169 out of 169 tests: 169 tests pass.
INFO: Build completed successfully, 178 total actions