-
Notifications
You must be signed in to change notification settings - Fork 890
Update expected iptable rule on smart switch #20271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
weiguo-nvidia
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
weiguo-nvidia:iptable_rule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If9bd7e108e14c7ffc4dc28b0cad91caef20362e0
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
approved these changes
Aug 17, 2025
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @prsunny , could you help review the PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Update expected iptable rule on smart switch
Fixes #
An new iptable was added on smart switch by PR sonic-net/sonic-host-services#301. After the change, a new rule
-A INPUT -d 169.254.200.254/32 -j ACCEPT
was generate after deploy minigraph.Need update function
generate_expected_rules
intests/cacl/test_cacl_application.py
to include this ruleNote: The current PR needs to be merged after sonic-net/sonic-host-services#301 merge
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Update function `generate_expected_rules
How did you verify/test it?
Regression pass
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation