Skip to content

Conversation

weiguo-nvidia
Copy link
Contributor

Description of PR

Summary: Update expected iptable rule on smart switch
Fixes #
An new iptable was added on smart switch by PR sonic-net/sonic-host-services#301. After the change, a new rule -A INPUT -d 169.254.200.254/32 -j ACCEPT was generate after deploy minigraph.
Need update function generate_expected_rules in tests/cacl/test_cacl_application.py to include this rule

admin@router:~$ sudo iptables -S
-P INPUT ACCEPT
-P FORWARD ACCEPT
-P OUTPUT ACCEPT
-A INPUT -s 127.0.0.1/32 -i lo -j ACCEPT
-A INPUT -d 169.254.200.254/32 -j ACCEPT             <<<
-A INPUT -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT

Note: The current PR needs to be merged after sonic-net/sonic-host-services#301 merge

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

Update function `generate_expected_rules

How did you verify/test it?

Regression pass

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Change-Id: If9bd7e108e14c7ffc4dc28b0cad91caef20362e0
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weiguo-nvidia
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weiguo-nvidia
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weiguo-nvidia
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roy-sror roy-sror requested a review from prsunny August 25, 2025 17:04
@weiguo-nvidia
Copy link
Contributor Author

Hi @prsunny , could you help review the PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants