Fix parse_chassis on partial lldp data #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
qiluo-msft
requested review from
tombo315,
jleveque,
lguohan and
pavel-shirshov
and removed request for
tombo315
lguohan
approved these changes
Jul 13, 2018
src/lldp_syncd/daemon.py
Outdated
| (rem_name, rem_attributes), = chassis_attributes.items() | ||
| chassis_id_subtype = str(self.ChassisIdSubtypeMap[rem_attributes['id']['type']].value) | ||
| chassis_id = rem_attributes['id']['value'] | ||
| (rem_name, rem_attributes) = chassis_attributes.items()[0] |
There was a problem hiding this comment.
We don't know the order in the dictionary. So [0] will not work.
It's better to check like
if 'id' In chassis_attributes.keys() #Resolved
Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>
pavel-shirshov
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in production and also manipulate unit test data to simulate this input behavior.