-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add stat_custom_receive0_management_mode to the Broadcom config file of TH5 platforms #22825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Fix is already merged: #18947. |
/azp run |
Commenter does not have sufficient privileges for PR 22825 in repo sonic-net/sonic-buildimage |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Rebased and updated releases to backport |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Cherry-pick PR to msft-202503: Azure/sonic-buildimage-msft#1206 |
…of TH5 platforms (sonic-net#22825) Add stat_custom_receive0_management_mode to the Broadcom config file of TH5 platforms
@kewei-arista please fix conflict and create PR to 202505 branch |
@yejianquan PR to 202505 branch: #22873 |
hi @kewei-arista could you check 202412 conflict? |
…of TH5 platforms (#1203) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Cherry pick changes from sonic-net/sonic-buildimage#22825 ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
… config file (#22998) Why I did it Recently we added stat_custom_receive0_management_mode config to TH5 Broadcom config files, and the changes upstreamed in #22825. There's a separate PR created to add new HWSKU Arista-7060X6-64PE-B-O128 around the same time, see #22672 As a result, stat_custom_receive0_management_mode was missed in Arista-7060X6-64PE-B-O128 config file. This change adds it. Work item tracking Microsoft ADO (number only): How I did it How to verify it Verified all interfaces are up with this change when using Arista-7060X6-64PE-B-O128
… config file … config file <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Recently we added stat_custom_receive0_management_mode config to TH5 Broadcom config files, and the changes upstreamed in sonic-net/sonic-buildimage#22825. There's a separate PR created to add new HWSKU Arista-7060X6-64PE-B-O128 around the same time, see sonic-net/sonic-buildimage#22672 As a result, stat_custom_receive0_management_mode was missed in Arista-7060X6-64PE-B-O128 config file. This change adds it. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it Verified all interfaces are up with this change when using Arista-7060X6-64PE-B-O128 <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft-202412 - [x] msft-202503 - [x] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
… config file … config file <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Recently we added stat_custom_receive0_management_mode config to TH5 Broadcom config files, and the changes upstreamed in sonic-net#22825. There's a separate PR created to add new HWSKU Arista-7060X6-64PE-B-O128 around the same time, see sonic-net#22672 As a result, stat_custom_receive0_management_mode was missed in Arista-7060X6-64PE-B-O128 config file. This change adds it. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it Verified all interfaces are up with this change when using Arista-7060X6-64PE-B-O128 <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft-202412 - [x] msft-202503 - [x] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
… config file (#23243) … config file <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Recently we added stat_custom_receive0_management_mode config to TH5 Broadcom config files, and the changes upstreamed in #22825. There's a separate PR created to add new HWSKU Arista-7060X6-64PE-B-O128 around the same time, see #22672 As a result, stat_custom_receive0_management_mode was missed in Arista-7060X6-64PE-B-O128 config file. This change adds it. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it Verified all interfaces are up with this change when using Arista-7060X6-64PE-B-O128 <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft-202412 - [x] msft-202503 - [x] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
…of TH5 platforms (sonic-net#22825) Add stat_custom_receive0_management_mode to the Broadcom config file of TH5 platforms
…a-7060X6-64PE-B-O128 config file (#1321) … config file <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Recently we added stat_custom_receive0_management_mode config to TH5 Broadcom config files, and the changes upstreamed in sonic-net/sonic-buildimage#22825. There's a separate PR created to add new HWSKU Arista-7060X6-64PE-B-O128 around the same time, see sonic-net/sonic-buildimage#22672 As a result, stat_custom_receive0_management_mode was missed in Arista-7060X6-64PE-B-O128 config file. This change adds it. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it Verified all interfaces are up with this change when using Arista-7060X6-64PE-B-O128 <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft-202412 - [x] msft-202503 - [x] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [x] msft-202412 #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
* [Arista] Add HWSKU Arista-7060X6-64PE-B-P64 (#22734) * Add qspf TH5-512 HWSKU Arista-7060X6-64PE-B-P64 * [Arista] Add HWSKU Arista-7060X6-64PE-B-P32O64 (#22732) [Arista] Add HWSKU Arista-7060X6-64PE-B-P32O64 * Add stat_custom_receive0_management_mode to the Broadcom config file of TH5 platforms (#22825) Add stat_custom_receive0_management_mode to the Broadcom config file of TH5 platforms * [Arista][DT2] Add QoS to Arista-7060X6-64PE-B-P32O64 (#22836) Why I did it Add QoS settings from CSP to TH5-512 HWSKU Arista-7060X6-64PE-B-P32O64 How to verify it Sanitized a fully wired DUT and confirmed all links came up. * [Arista][DT2] Add QoS to Arista-7060X6-64PE-B-P64 (#22837) Why I did it Add QoS settings from CSP to TH5-512 HWSKU Arista-7060X6-64PE-B-P64 How to verify it Sanitized a fully wired DUT and confirmed all links came up. * Enable srv6 on TH5 (#23018) Why I did it Enable srv6 on TH5 * Set ENABLE to 0 for TH5 platform (#23125) Why I did it Fixed aristanetworks/sonic-qual.msft#645 How I did it Update bcm config to set ENABLE to 0. How to verify it The change is verified by modifying the bcm config and checking if all ports can be up. --------- Co-authored-by: kewei-arista <146126091+kewei-arista@users.noreply.github.com> Co-authored-by: Dayou Liu <113053330+dayouliu1@users.noreply.github.com> Co-authored-by: bingwang-ms <66248323+bingwang-ms@users.noreply.github.com>
Why I did it
There's an upgrade in SAI / SDK so that we need to add
stat_custom_receive0_management_mode
to config files of TH5 products. Plesae see Broadcom article "SDK - API Behavior Change - Statistics counter: snmpBcmCustomReceive0 is reserved" (ID: 26564) for more details.Without this change, we'll see
orchagent
crashing with following errors:Work item tracking
How I did it
Update the Broadcom config files based on the suggestion provided by Broadcom
How to verify it
We verified the crash is fixed with this patch, and running
sonic-mgmt
with this patch.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)