Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Symfony 4.4 and Twig 2 #1739

Merged

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Changelog

### Removed
- Support for Symfony 4.4
- Support for Twig 2

@jordisala1991
Copy link
Member Author

I have added more database versions to test (more postgres and mysql versions). Modified php version for those tests too.

@VincentLanglet
Copy link
Member

There is still tags for twig 2 https://github.com/twigphp/Twig/tags, is it really abandonned ?

@jordisala1991
Copy link
Member Author

We are dropping it on next majors anyway, why not do it right away? https://packagist.org/packages/twig/twig#v3.0.0 twig 3 is more than 3 years old...

@VincentLanglet
Copy link
Member

We are dropping it on next majors anyway, why not do it right away? packagist.org/packages/twig/twig#v3.0.0 twig 3 is more than 3 years old...

I just dont know this package enough to know if there was a reason for twig to not abandon the v2. Maybe some people are stuck with v2 for some weird reason...

@jordisala1991 jordisala1991 merged commit 4c1ba22 into sonata-project:4.x Apr 18, 2023
@jordisala1991 jordisala1991 deleted the improvement/drop-symfony-4.4 branch April 18, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants