Enhancement: Introduces PagerInterface::isDeterministic
(refs #8164)
#8205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This is my suggestion to indicate an enduser that the list doesn't know how many elements ("all elements") will be affected by now. I decided to use a universal
+
sign to indicate it.Default behavior:
Behavior
SimplePager
:I'm not sure if I should add this to
abstract Pager
class without finalizing it. I rather suggest to implementabstract function isDeterministic
and force any implementation of Pager to set it. WDYT? As this is not BC, I didn't choose this path (any custom implementation might be broken after a patch/minor update).This refs #8164 but does not finally closes it. I'll update the way
SimplePager
count results using thresholds in a separate MR. Together they will solve #8164.I am targeting this branch, because it's BC.
Refs #8164
Changelog