Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Introduces PagerInterface::isDeterministic (refs #8164) #8205

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

mvhirsch
Copy link
Contributor

Subject

This is my suggestion to indicate an enduser that the list doesn't know how many elements ("all elements") will be affected by now. I decided to use a universal + sign to indicate it.

Default behavior:

image

Behavior SimplePager:

image

I'm not sure if I should add this to abstract Pager class without finalizing it. I rather suggest to implement abstract function isDeterministic and force any implementation of Pager to set it. WDYT? As this is not BC, I didn't choose this path (any custom implementation might be broken after a patch/minor update).

This refs #8164 but does not finally closes it. I'll update the way SimplePager count results using thresholds in a separate MR. Together they will solve #8164.

I am targeting this branch, because it's BC.

Refs #8164

Changelog

### Added
- Introduces `PagerInterface::isDeterministic` to render yet unknown result count in `SimplePager` properly

@mvhirsch mvhirsch changed the title Enhancement: Introduces PagerInterface::isDeterministic (refs #8164) Enhancement: Introduces PagerInterface::isDeterministic (refs #8164) Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant