Enable security information mapping for RoleSecurityHandler #8192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
force-pushed
the
role-information-mapping
branch
from
4ecfdde
to
116fb8b
Compare
phansys
reviewed
Jul 5, 2024
core23
force-pushed
the
role-information-mapping
branch
2 times, most recently
from
3cd9930
to
c57d8ba
Compare
core23
force-pushed
the
role-information-mapping
branch
from
c57d8ba
to
4f7f945
Compare
VincentLanglet
requested changes
Jul 11, 2024
core23
force-pushed
the
role-information-mapping
branch
from
4f7f945
to
ba3b4cf
Compare
VincentLanglet
approved these changes
Jul 14, 2024
phansys
approved these changes
Jul 14, 2024
|
phpstan is also failing on the dev-kit PRs :( https://github.com/sonata-project/SonataAdminBundle/actions/runs/9930955039/job/27430272674?pr=8195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this feature is BC.
Finally provide #4925 feature
Changelog
If you want to combine multiple permissions, you can now use the
sonata.admin.security.handler.rolefor this.If you have a user with a
ROLE_ACME_ADMIN_VIEWERpermission, the security handler will work if your admin asks for VIEW, LIST or EXPORTER grants.The changes are BC, because if will also work if you have no special information mapping.