Skip to content

Conversation

oclyke
Copy link

@oclyke oclyke commented Sep 18, 2024

Hi there.

Thanks a bunch for maintaining this library.

This PR makes it easy to include the library when it is not directly within the components directory by simply setting the ESP_DMX_ROOT variable before including the CMakeLists.txt file.

This allows users to create a simple wrapper component like this:

# components/esp_dmx_wrapper/CMakeLists.txt
set(ESP_DMX_ROOT <path to esp_dmx>)
include("${ESP_DMX_ROOT}/CMakeLists.txt")

The benefit, to me, is that I can keep all my third-party dependencies / submodules in one place. It makes it easier not to miss one ;)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant