Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update paths #211

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Update paths #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Contributing

Thank you for showing your interest in contributing! Contributions are most welcome. Anything including small fixes is greatly appreciated.

> [!NOTE]
Expand All @@ -16,6 +17,7 @@ Inkscape usually saves into its own _'Inkscape SVG'_ format with additional data
Frequently, app icons have different names used on different systems and/or app versions. So the general rule is to create one actual `.svg` icon with either the simplest or most frequently used name and then create symlinks to it with all the alternative names. Check the existing icons for examples of how things are done there. For a source of possible app names check the [Papirus icon theme](https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/).
> [!IMPORTANT]
> The symlinks have to be created from within the same directory as the actual `.svg` file without using any paths to avoid hardcoding them, like so:

```sh
ln -s original-name.svg alternativeName.svg
```
Expand All @@ -29,9 +31,10 @@ The icons used on the modern and legacy full-color folder icons may or may not d

**6. Always update `meson.build` files before committing**
When you're done with your changes, run the dev script from within the theme's root directory once for every folder you've added new icons or made changes to, like so:

```sh
./_dev/dump_groups.py apps/scalable
./_dev/dump_groups.py apps/symbolic
./_dev/dump_groups.py scalable/apps
./_dev/dump_groups.py symbolic/apps
```

**7. Use separate pull requests**
Expand Down
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
> [!NOTE]
> In v47 the folder structure has changed. If you've set custom folder icons, upgrading from a previous version of MoreWaita will break those. You'll need to reassign folder icons after upgrading.
> In v47 the folder structure has changed. If you've set custom folder icons, upgrading from a previous version of MoreWaita will break those. You'll need to reassign folder icons after upgrading.

# MoreWaita

Expand Down Expand Up @@ -432,6 +432,7 @@ _These are the icons currently in git, versioned theme releases will be behind m
![icon](./scalable/places/folder-work.svg "Work")

### Legacy Places

![icon](./scalable/places/folder-android-legacy.svg "Android")
![icon](./scalable/places/folder-appimage-legacy.svg "AppImage")
![icon](./scalable/places/folder-archlinux-legacy.svg "Arch Linux")
Expand Down Expand Up @@ -558,7 +559,7 @@ gsettings set org.gnome.desktop.interface icon-theme 'MoreWaita'
3. Right click on the folder.
4. Click on `Properties`.
5. Click on the folder image.
6. Navigate to the MoreWaita installation folder and into the `places` subfolder (typically `/usr/share/icons/MoreWaita/places/scalable/`).
6. Navigate to the MoreWaita installation folder and into the `places` subfolder (typically `/usr/share/icons/MoreWaita/scalable/places/`).
7. Select the icon you wish to use.
8. Click `Open`.
9. Follow the same procedure to revert the icon. Just click `Revert` instead of selecting a new icon in step 7.
Expand All @@ -572,7 +573,7 @@ If you need to assign the icons using the CLI you have to use the GIO command-li

```sh
gio set $HOME/Coding/C metadata::custom-icon \
file:///usr/share/icons/MoreWaita/places/scalable/folder-c.svg
file:///usr/share/icons/MoreWaita/scalable/places/folder-c.svg
```

- You can confirm the change showing the `metadata::custom-icon` attribute with:
Expand Down