Allowing use as a package

[teamcoltra]

I’m planning to tweak the project a bit so I can use it more like a package, with some added flexibility for external use. A couple things are a bit tricky to adjust right now — for example, indentation levels and the font file directory, which seems to be hardcoded.

Would you be open to me taking a pass at these and submitting a PR? Or do you prefer to keep this project tightly scoped as a CLI tool? Totally fair either way, if you'd rather keep things focused I’ll probably fork it and give it a new name to make it clear it’s a separate direction. In that case, I’d likely strip out the CLI parts and not worry about staying compatible.

Here’s a rough list of what I’m planning to look into (some of these might be fixable with config or flags, so I may not need to touch the code for all of them):

• Emphasized text isn’t rendering properly in bulleted lists (like this one).
• Indentation can’t currently be adjusted.
• Font folder seems fixed to the root directory — would be great to make that configurable.
• Might be upstream in gomarkdown, but you currently need a leading blank line before an unordered list for it to render. I believe that’s technically Markdown standards compliant, but GitHub-flavored Markdown doesn’t require it, so I’d like to see if I can enable GitHub flavoured markdown.

Let me know what you think! Happy to contribute or fork depending on your goals for the project. Thank you so much for the work you've already done on this. I'm using it right now to generate my resumes in my program and even using it as a package as it is has got me to a point where it's not terrible.

[jessp01]

Hi @teamcoltra ,

Glad to hear you find this project useful.
I'm certainly open to contributions and, as long as none of the functionality is hindered, I'll be happy to review and, once all is well, merge:)

Indentation can’t currently be adjusted.

Can you elaborate on this one?

Emphasized text isn’t rendering properly in bulleted lists (like this one).

Never tried that one, myself. If you're working on a fix, please be sure to also include a test file here https://github.com/solworktech/md2pdf/tree/master/testdata and edit https://github.com/solworktech/md2pdf/blob/master/mdtopdf_test.go accordingly. I've inherited these units and one day, I will probably refactor them such that editing mdtopdf_test.go is no longer necessary for the simple purpose of adding a test case (easy enough to implement a scandir with test inputs) but for now, it is what it is and it does get the job done.

Cheers,

[teamcoltra]

Can you elaborate on this one?

For my purposes (and aesthetics) the indentation on lists is too far in. That should be configurable, but I don't think it currently is.

[jessp01]

Hi @teamcoltra ,

For my purposes (and aesthetics) the indentation on lists is too far in. That should be configurable, but I don't think it currently is.

Got it. I did reduce the indention in a recent version but I've no objection to code that makes it configurable.