Skip to content

/user/top_100 엔드포인트 추가, Problem 스키마 수정 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2023

Conversation

dev-ruby
Copy link
Member

@dev-ruby dev-ruby commented May 8, 2023

Problem 스키마를 현재 API에 맞게 수정했습니다.

수정사항

  • titles 요소 추가
  • sprout 요소 추가
  • givesNoRating 요소 추가
  • official 요소 추가
  • example 값을 현재에 맞게 수정

/user/top_100 엔드포인트를 추가했습니다.

#53
#50

dev-ruby added 3 commits May 8, 2023 22:31
Problem 스키마를 현재 API에 맞게 수정했습니다.

수정사항
- titles 요소 추가
- sprout 요소 추가
- givesNoRating 요소 추가
- official 요소 추가
- example 값을 현재에 맞게 수정
/user/top_100 엔드포인트를 추가했습니다.
Copy link
Collaborator

@kiwiyou kiwiyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dev-ruby
Copy link
Member Author

dev-ruby commented May 9, 2023

현재 API에 맞게 /search/suggestion 엔드포인트를 수정했습니다

변경사항

  • 문제 반환 형식 변경
  • 태그 반환 형식 변경
  • 유저 반환 형식 변경
  • 문제, 태그, 유저가 최대 5개씩까지만 반환된다는 점 명시
  • example 값 변경

유저 반환 형식이 User 스키마와 비슷하지만, rank 값이 빠져있습니다.

image
image
image


브랜치를 바꾸고 커밋했어야 하는데 실수로 같은 브랜치에 커밋을 해버려서 여기 올립니다..

@dev-ruby dev-ruby requested a review from kiwiyou May 10, 2023 05:58
Copy link
Collaborator

@kiwiyou kiwiyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiwiyou kiwiyou merged commit 843eaf3 into solvedac:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants