Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable decompressors again #98

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Disable decompressors again #98

merged 1 commit into from
Apr 19, 2021

Conversation

joshuaspence
Copy link
Contributor

After upgrading to Packer 1.7 I noticed that RaspiOS is being downloaded on every Packer run (as in #44). It appears that this regression was caused by #95, which upgrades to version 2 of go-getter.

@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

After upgrading to Packer 1.7 I noticed that RaspiOS is being downloaded on every Packer run (as in #44). It appears that this regression was caused by #95, which upgrades to version 2 of `go-getter`.
@joshuaspence
Copy link
Contributor Author

I'm having trouble figuring out why the tests are failing

@yuval-k
Copy link
Member

yuval-k commented Apr 16, 2021

thank you @joshuaspence !
try running go mod tidy; go mod vendor (using go 1.16)
if that doest solve it, let me know and i'll merge this PR and figure it out the issue after it is merged

@joshuaspence
Copy link
Contributor Author

Thanks for the suggestion @yuval-k but it didn't seem to work. In fact, I had already run those commands.

@yuval-k
Copy link
Member

yuval-k commented Apr 19, 2021

ok, i'm merging this and will figure this out later.
thanks @joshuaspence

@yuval-k yuval-k merged commit 6238af4 into solo-io:master Apr 19, 2021
@joshuaspence joshuaspence deleted the decompressors branch April 20, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants