[gateway2] Updates Gateway Controller Watch Predicate #10107
+125
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehans
force-pushed
the
issue_10098
branch
from
e362896
to
a16fce8
Compare
|
Issues linked to changelog: |
danehans
force-pushed
the
issue_10098
branch
from
a16fce8
to
81a0892
Compare
EItanya
reviewed
Sep 25, 2024
danehans
force-pushed
the
issue_10098
branch
2 times, most recently
from
2f27f38
to
2996810
Compare
|
/kick |
timflannagan
approved these changes
Sep 27, 2024
jenshu
reviewed
Sep 27, 2024
danehans
force-pushed
the
issue_10098
branch
2 times, most recently
from
82142c3
to
f3d37ef
Compare
Previously, the controller would only watch Gateway objects for `generation` field changes which is not updated when annotations change. Since Gateway reconciliation should be triggered when the `gateway.gloo.solo.io/gateway-parameters-name` annotation is added, removed, or modified, the predicate was updated to check for changes in either the generation field or the annotations. Fixes solo-io#10099 Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
danehans
force-pushed
the
issue_10098
branch
from
f3d37ef
to
73aa22f
Compare
jenshu
approved these changes
Oct 1, 2024
| s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams, proxyService, proxyDeployment) | ||
| err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsManifestFile) | ||
| s.NoError(err, "can delete manifest") | ||
| s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams) |
There was a problem hiding this comment.
maybe a merge issue but can this line be deleted since we also check gwParams below?
Comment on lines
+62
to
+70
| s.NoError(err, "can delete manifest") | ||
| s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gtw) | ||
|
|
||
| err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsManifestFile) | ||
| s.NoError(err, "can delete manifest") | ||
| s.testInstallation.Assertions.EventuallyObjectsNotExist(s.ctx, gwParams) | ||
|
|
||
| err = s.testInstallation.Actions.Kubectl().DeleteFile(s.ctx, gwParamsCustomManifestFile) | ||
| s.NoError(err, "can delete manifest") |
There was a problem hiding this comment.
nit: can all the NoError have different error messages (e.g. append the manifest filename)?
jenshu
reviewed
Oct 1, 2024
| @@ -0,0 +1,10 @@ | |||
| changelog: | |||
There was a problem hiding this comment.
need to move changelog to beta24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the controller would only watch Gateway objects for
generationfield changes which is not updated when annotations change. Since Gateway reconciliation should be triggered when thegateway.gloo.solo.io/gateway-parameters-nameannotation is added, removed, or modified, the predicate was updated to check for changes in either the generation field or the annotations.Fixes #10099