Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect ExpressPeerServer to client using Socket.io #9

Merged
merged 31 commits into from
Feb 4, 2021
Merged

connect ExpressPeerServer to client using Socket.io #9

merged 31 commits into from
Feb 4, 2021

Commits on Jan 21, 2021

  1. add socket.io package

    David Solis committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    69fdf85 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. create room.ts as a sandbox for our experiment 

    we want to use the original code for the RoomServer
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d08907d View commit details
    Browse the repository at this point in the history

  2. paste the original RoomServer in 

    and use it as a sub-express app of the ExpressPeerServer
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d530e24 View commit details
    Browse the repository at this point in the history

  3. remove custom key option from ExpressPeerServer config

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0f60aa6 View commit details
    Browse the repository at this point in the history

  4. attach socket.io server to ExpressPeerServer 

    instead of making it a sub express app
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    81b4cbf View commit details
    Browse the repository at this point in the history

  5. fix linter errors

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    8a7146f View commit details
    Browse the repository at this point in the history

  6. remove redundant cors checking 

    ExpressPeerServer already allows cors request from needed urls
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    aabd402 View commit details
    Browse the repository at this point in the history

  7. configure socket.io path for server 

    do not serve client files for server
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    11e11ca View commit details
    Browse the repository at this point in the history

  8. replaced default key

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    45898cf View commit details
    Browse the repository at this point in the history

  9. formatting

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    dd3233c View commit details
    Browse the repository at this point in the history

  10. encapsulate vercel host in env variable

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0b4e4d4 View commit details
    Browse the repository at this point in the history

  11. print out unknown origin when denying CORS requests

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    2206d61 View commit details
    Browse the repository at this point in the history

  12. use the experimental starting file

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    68e7759 View commit details
    Browse the repository at this point in the history

  13. default allow CORS requests for socket.io

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    e6df62d View commit details
    Browse the repository at this point in the history

  14. use allowList for socket.io CORS

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    55240b6 View commit details
    Browse the repository at this point in the history

  15. formatting

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    1aa9616 View commit details
    Browse the repository at this point in the history

  16. rename iClient interface to Client

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    363644e View commit details
    Browse the repository at this point in the history

  17. remove extra line

    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    974bc42 View commit details
    Browse the repository at this point in the history

  18. log socket.io disconnect and disconnecting reason 

    https://socket.io/docs/v3/server-api/#Event-‘connection’
    David Solis committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    570db31 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. throw error if server receives join room request without roomId or us… 

    …erId
    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    182ab95 View commit details
    Browse the repository at this point in the history

  2. log user joining and leaving room

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b1f540d View commit details
    Browse the repository at this point in the history

  3. rename client to PeerClient

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    853a61e View commit details
    Browse the repository at this point in the history

  4. rename IClient interface to Client

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    40f0658 View commit details
    Browse the repository at this point in the history

  5. log peerServer connections as PeerClient

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3673afc View commit details
    Browse the repository at this point in the history

  6. encapsulate vercel uri in env variable

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e6a9746 View commit details
    Browse the repository at this point in the history

  7. display rejected origin in CORS error

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f2d6864 View commit details
    Browse the repository at this point in the history

  8. remove key from server uri start path

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    18948ac View commit details
    Browse the repository at this point in the history

  9. stop overriding peerServer endpoints 

    redundant and interferes with peer middleware calls
    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    dae08ee View commit details
    Browse the repository at this point in the history

  10. add socket.io to ExpressPeerServer

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    97b6c91 View commit details
    Browse the repository at this point in the history

  11. update review app success url

    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    feb74b5 View commit details
    Browse the repository at this point in the history

  12. remove room test server 

    point all start commands to index.js
    David Solis committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    19c713a View commit details
    Browse the repository at this point in the history