Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set HTTP Headers before GET & POST requests #3

Merged
merged 2 commits into from
Jan 9, 2021
Merged

Set HTTP Headers before GET & POST requests #3

merged 2 commits into from
Jan 9, 2021

Conversation

soliskit
Copy link
Owner

@soliskit soliskit commented Jan 9, 2021

David Solis added 2 commits January 8, 2021 18:22
define app routes after http headers have been set
a237716 
by combining peerServer with expressServer before route definition, it avoids http headers being set during requests
print peerServer url on mount
ecd4383 
express app settings retrieves its env value NODE_ENV
Heroku defaults set NODE_ENV to production
soliskit
soliskit commented Jan 9, 2021
View reviewed changes
src/index.ts Show resolved Hide resolved
@soliskit soliskit merged commit 2212a23 into main Jan 9, 2021
@soliskit soliskit deleted the fix/http-headers branch January 9, 2021 02:27
@soliskit soliskit restored the fix/http-headers branch January 9, 2021 02:28
@soliskit soliskit deleted the fix/http-headers branch January 9, 2021 02:30
@soliskit soliskit mentioned this pull request Feb 27, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soliskit