Handle partial captures #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 99.56% 99.58% +0.01%
==========================================
Files 26 26
Lines 460 477 +17
==========================================
+ Hits 458 475 +17
Misses 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
approved these changes
Mar 31, 2023
rainerdema
reviewed
Mar 31, 2023
app/subscribers/solidus_stripe/webhook/payment_intent_subscriber.rb
Outdated
Show resolved
Hide resolved
waiting-for-dev
force-pushed
the
waiting-for-dev/partial_capture
branch
from
e47d22a to
2e20c51
Compare
Stripe allows for a payment to be partially captured, creating a refund for the remaining amount [1]. We're now acting accordingly by changing how we handle the `payment_intent.succeeded` webhook. When the capture is total, we do as before. For partial captures, on top of the latter, we create a Solidus refund for the uncaptured amount. [1] - https://stripe.com/docs/payments/place-a-hold-on-a-payment-method#capture-funds Closes #221
waiting-for-dev
force-pushed
the
waiting-for-dev/partial_capture
branch
from
2e20c51 to
f3632d5
Compare
kennyadsl
reviewed
Apr 11, 2023
rainerdema
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for looking into this @waiting-for-dev 🙌 Looks great!
kennyadsl
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stripe allows for a payment to be partially captured, creating a refund for the remaining amount.
We're now acting accordingly by changing how we handle the
payment_intent.succeededwebhook. When the capture is total, we do as before. For partial captures, on top of the latter, we create a Solidus refund for the uncaptured amount.Closes #221
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: