[v4.3] Merge pull request #371 from solidusio/fix-install #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fresh Rails apps with Stimulus installed already have a `app/javascript/controller/index.js` file with boilerplate code. Since we install this file as well we need to overwrite it if auto acept is enabled. (cherry picked from commit 96aa506)
Since Chrome 128 there is a Search Engine selection popup even in headless mode that needs to be accepted. This leads to Capybara Element not found exceptions during system specs. Refs: SeleniumHQ/selenium#14438 (cherry picked from commit c368c16)
3 tasks
This was referenced Aug 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.3 #372 +/- ##
==========================================
- Coverage 95.99% 95.98% -0.02%
==========================================
Files 207 207
Lines 4874 4876 +2
==========================================
+ Hits 4679 4680 +1
- Misses 195 196 +1 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.3:Questions ?
Please refer to the Backport tool documentation