This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Make use of data collector in JS configurable #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Sep 26, 2019
|
What about we go ahead with this for now and create the configuration object once #236 is merged? |
mamhoff
force-pushed
the
make-data-collection-configurable
branch
from
575a014 to
db900cf
Compare
mamhoff
force-pushed
the
make-data-collection-configurable
branch
from
db900cf to
f0c5da6
Compare
|
@seand7565 I think this does the trick - sorry I took a bit longer :) |
seand7565
reviewed
Nov 12, 2020
There was a problem hiding this comment.
This looks great, thanks! Just one thing - can you add something to the README about this option? Maybe under the PayPal section, something like:
For fraud prevention, PayPal recommends using a data collector to collect device information, which we've included. You're able to turn off the PayPal data collector on the payment method options if you desire.
|
@seand7565 Added the documentation! |
|
@mamhoff can you please rebase now that we have specs running against 3.0 as well? Thanks! |
Some stores do not want or need to do invasive fraud protection. For these, it should be possible to turn data collection off without overwriting partials.
This adds a bit of documentation about the Paypal Data Collector preference.
mamhoff
force-pushed
the
make-data-collection-configurable
branch
from
4a0ad55 to
f29f79c
Compare
kennyadsl
approved these changes
Sep 20, 2021
kennyadsl
requested review from
tvdeyen,
aldesantis,
jarednorman and
spaghetticode
tvdeyen
approved these changes
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stores do not want or need to do invasive fraud protection. For
these, it should be possible to turn data collection off without
overwriting partials.