Skip to content

Remove deprecated bin/r and bin/sandbox_rails binaries #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Jun 8, 2020
Merged

Remove deprecated bin/r and bin/sandbox_rails binaries #118

mergify merged 1 commit into from
Jun 8, 2020

Conversation

@aldesantis
Copy link
Member

@aldesantis aldesantis commented Jun 5, 2020

Summary

Removes the deprecated bin/r and bin/sandbox_rails binaries. This isn't a breaking change, since the binaries have already been generated in existing extensions and won't be removed unless the author does it explicitly.

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

@aldesantis aldesantis added the removed Removes an existing functionality. label Jun 5, 2020
@aldesantis aldesantis requested a review from elia June 5, 2020 14:29
@aldesantis aldesantis self-assigned this Jun 5, 2020
@aldesantis aldesantis removed the removed Removes an existing functionality. label Jun 5, 2020
@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Jun 5, 2020
@aldesantis aldesantis added removed Removes an existing functionality. needs changelog label Needs a label to determine the type of change. and removed needs changelog label Needs a label to determine the type of change. removed Removes an existing functionality. labels Jun 5, 2020
@aldesantis aldesantis force-pushed the aldesantis/remove-deprecated-binaries branch from 125869b to f54149d Compare June 5, 2020 15:39
@solidusio solidusio deleted a comment from mergify bot Jun 5, 2020
@aldesantis aldesantis added blocked Blocked by external factors. removed Removes an existing functionality. and removed blocked Blocked by external factors. labels Jun 5, 2020
@elia elia mentioned this pull request Jun 8, 2020
Open
@mergify mergify bot merged commit 18f56f5 into master Jun 8, 2020
@mergify mergify bot deleted the aldesantis/remove-deprecated-binaries branch June 8, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elia elia elia approved these changes

Assignees

@aldesantis aldesantis

Labels

removed Removes an existing functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aldesantis @elia