Change solidus dependency to components #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem currently depends on solidus (which is a meta gem for all solidus modules). This means that even if the site does not use solidus_frontend, this gem will require it to be installed. This changes the dependency to only include solidus_core and solidus_api which are the components this actually requires.
|
Failing test is due to a phantomjs crash. |
|
👍 |
gsmendoza
pushed a commit
to gsmendoza/solidus_braintree
that referenced
this pull request
Dec 28, 2022
Add Braintree configuration to Spree::Store model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem currently depends on solidus (which is a meta gem for all
solidus modules). This means that even if the site does not use
solidus_frontend, this gem will require it to be installed.
This changes the dependency to only include solidus_core and solidus_api
which are the components this actually requires.