Get client token from braintree only in the payment page. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectoregm
force-pushed
the
hectoregm/admin_ui
branch
from
32b35d3 to
f3e149a
Compare
|
👍 sorry for not taking this sooner! |
gsmendoza
pushed a commit
to gsmendoza/solidus_braintree
that referenced
this pull request
Dec 28, 2022
Enable Braintree credit card payments via hosted fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are trying to get a client token at every page load in the Admin UI, that creates
a 404 response in all pages except the payment page this manifest as an empty flash error
in the UI, this PR makes it so that only we request the client token for Braintree only in the
payment page in the backend.