Use braintree's Hosted Fields #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
force-pushed
the
hosted_fields
branch
from
1d59a89 to
846ddfc
Compare
Merged
| <%= fields_for "#{param_prefix}[address_attributes]", @order.bill_address do |f| %> | ||
| <%= render :partial => 'spree/address/form_hidden', :locals => { :form => f } %> | ||
| <div class="braintree-payment"> | ||
| <input type="text" class="braintree-input-style"></input> |
There was a problem hiding this comment.
This input is needed for what purpose ?
This was referenced Apr 26, 2016
Merged
jhawthorn
force-pushed
the
hosted_fields
branch
3 times, most recently
from
d960e38 to
0f8fc16
Compare
jhawthorn
force-pushed
the
hosted_fields
branch
from
0f8fc16 to
b903e5b
Compare
gsmendoza
pushed a commit
to gsmendoza/solidus_braintree
that referenced
this pull request
Dec 28, 2022
…ogged-in Only prompt for email for not logged in users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Built ontop of #25
This allows stores to easily add this gem and only require easiest level of PCI compliance, SAQ A.
The downside is that this involves using weird
<iframe>s inside of the checkout page, which are awkward to style. This offering also has worse formatting than that provided byjquery.payments, but Braintree promises something better Soon™ braintree/braintree-web#77. I believe this is worth those trade-offs.