Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update braintree-web to 2.23.0 #24

Merged
merged 2 commits into from
Apr 21, 2016

Conversation

hectoregm
Copy link
Contributor

Update to braintree-web 2.23.0 needed for implementation of fraud prevention using deviceData.

@cbrunsdon
Copy link
Contributor

cbrunsdon commented Apr 21, 2016

Hi @hectoregm,

I'd prefer that we drop the explicit version on the asset and instead just make it "vendor/braintree.js"

With this bump, the now-merged change in #22 wouldn't work, and anyone that was explicitly including the file in their assets would also break (removing the version would still break them, of course, but just once more instead of every time we bump).

@hectoregm
Copy link
Contributor Author

Ok I will make the change then.

@hectoregm hectoregm force-pushed the braintree-web-2-23-0 branch from 22fd17b to fdc84f2 Compare April 21, 2016 19:37
@jhawthorn
Copy link
Contributor

Thank you @hectoregm

@jhawthorn jhawthorn merged commit 268d2eb into solidusio:master Apr 21, 2016
@hectoregm hectoregm deleted the braintree-web-2-23-0 branch April 25, 2016 12:26
gsmendoza pushed a commit to gsmendoza/solidus_braintree that referenced this pull request Dec 28, 2022
Validate address before processing imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants